-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110276/#review31954
-----------------------------------------------------------
Ship it!
>> At least the "now playing" edit field has a height without top/bottom space.
>Sorry, I'm still not sure what you mean here. :(
My concerns apply to the icons only. But don't care too much, it looks fine all
in all.
>> What's about the idea to separate the "Now playing" stuff, with the benefit
>> of room for support?
>To be honest, I don't like it. It splits the dialog in two pages, which tends
>make it more difficult to find the option you're looking for quickly.
Agreed.
>Besides that...To put it differently, I wouldn't even know what kind of
>instructions to put there...
I guess (or rather misapprehended) that more than the given variables can be
assigned.
I'm using audacious and there is a dropdown with predefined strings (e.g.
"ALBUM - TITLE" = ${?album:${album} - }${title}, and you can combine variables
freely from another menu (including the very important information codec,
quality etc.). That makes probably no sense in your context (and I don't
understand at all, why anybody wants to tell the world what he or she is
listening to) and could be improved on demand.
Two more thing: When you disable an input you should do it for all related
controls too. "Not available" is unchecked and time cannot be set but the
labels are still active (I wonder what happen when you access the disabled
control per shortcut). Same applies to message label below.
And do you write Download Folder intentionally with capital letter?
File Attachment: new settings dialog as of diff revision 2
<http://git.reviewboard.kde.org//r/110276/#fcomment50>
No space to top and bottom for icons
- Heiko Tietze
On May 3, 2013, 2:07 p.m., Sven Brauch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110276/
> -----------------------------------------------------------
>
> (Updated May 3, 2013, 2:07 p.m.)
>
>
> Review request for Telepathy, KDE Usability, David Edmundson, and Martin
> Klapetek.
>
>
> Description
> -------
>
> This patch revamps the settings UI of the kded module. Especially, it removes
> the "flat" flag from the group boxes, and also removes lots of spacers. But
> talk doesn't really help with UI changes, so you'd better look at the
> screenshot below ;)
>
> Additionally, I'd like to add a dialog->resize(700, 640) to
> ContactListWidget::showSettingsKCM() in contact-list-widget.cpp in
> ktp-contactlist (the function which opens the dialog), but I don't want to
> open a seperate review for that.
>
>
> Diffs
> -----
>
> config/telepathy-kded-config.cpp 50c176d
> config/telepathy-kded-config.ui 54ebc54
>
> Diff: http://git.reviewboard.kde.org/r/110276/diff/
>
>
> Testing
> -------
>
> The settings dialog still seems to work fine.
>
>
> File Attachments
> ----------------
>
> Old (left) and new (right) settings dialog, with their respective default
> sizes
>
> http://git.reviewboard.kde.org/media/uploaded/files/2013/05/02/ktp-settings.png
> new settings dialog as of diff revision 2
>
> http://git.reviewboard.kde.org/media/uploaded/files/2013/05/03/ktp-settings-new2.png
>
>
> Thanks,
>
> Sven Brauch
>
>
_______________________________________________
KDE-Telepathy mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-telepathy
