----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110276/#review31942 -----------------------------------------------------------
Ship it! Looks good; any other comments can be incorporated later. >From a developer POV it's awkward for me to review multiple changes in one >patch which is where the current review comments are heading. - David Edmundson On May 3, 2013, 1:21 p.m., Sven Brauch wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110276/ > ----------------------------------------------------------- > > (Updated May 3, 2013, 1:21 p.m.) > > > Review request for Telepathy, KDE Usability, David Edmundson, and Martin > Klapetek. > > > Description > ------- > > This patch revamps the settings UI of the kded module. Especially, it removes > the "flat" flag from the group boxes, and also removes lots of spacers. But > talk doesn't really help with UI changes, so you'd better look at the > screenshot below ;) > > Additionally, I'd like to add a dialog->resize(700, 640) to > ContactListWidget::showSettingsKCM() in contact-list-widget.cpp in > ktp-contactlist (the function which opens the dialog), but I don't want to > open a seperate review for that. > > > Diffs > ----- > > config/telepathy-kded-config.cpp 50c176d > config/telepathy-kded-config.ui 54ebc54 > > Diff: http://git.reviewboard.kde.org/r/110276/diff/ > > > Testing > ------- > > The settings dialog still seems to work fine. > > > File Attachments > ---------------- > > Old (left) and new (right) settings dialog, with their respective default > sizes > > http://git.reviewboard.kde.org/media/uploaded/files/2013/05/02/ktp-settings.png > new settings dialog as of diff revision 2 > > http://git.reviewboard.kde.org/media/uploaded/files/2013/05/03/ktp-settings-new2.png > > > Thanks, > > Sven Brauch > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
