https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18086

--- Comment #33 from Baptiste Wojtkowski (bwoj) 
<[email protected]> ---
Created attachment 168815
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168815&action=edit
Bug 18086: Fix the behaviour of GetOverdueMessageTransportTypes

See https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18086#c27
for more context :
This addresses the second point of this comment.

Test concerning GetOverdueMessageTransportTypes were not passing anymore after
previous patch.

This was due to the behaviour of Koha::Overdue->get_message_types which
returns all messages from a rule id, not taking into account the
letternumber when considering a OverdueRule (which is totally normal).
I fixed the join in GetOverdueMessageTransportTypes to return directly the
desired column and use it in the
rest of the code

Note: Koha::Overdue->get_message_types might not be necessary anymore

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to