https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18086
--- Comment #40 from Baptiste Wojtkowski (bwoj) <[email protected]> --- (In reply to Victor Grousset/tuxayo from comment #38) > (In reply to Baptiste Wojtkowski (bwoj) from comment #27) > > I think this is a bug due to "GetOverdueMessageTransportTypes" returning > > ['email', 'sms', 'email'] in all these three tests, instead of returning > > ['email'], then ['sms'], and then ['email'] > > Indeed, Koha::Overdue->getmessagetransporttype returns every entries related > > to one given rule id, which may have multiple letternumbers, which are not > > taken anymore in account at this point of the code. > > I am not sure of the purpose of Koha::Overdue->getmessagetransporttype but i > > would delete it and directly use the join (not proposed in this patch). > > Where is that existing `Koha::Overdue->getmessagetransporttype` whose > purpose needs to be confirmed? Sorry, I am talking about the method added by the first version of the patch Koha::Overduerule::transport_types. It is the method I stop using line 790 in the followup https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168815&action=diff -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
