https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18086
--- Comment #37 from Victor Grousset/tuxayo <[email protected]> --- Comment on attachment 168812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168812 Bug 18086: Fix issues with NULL for branches Review of attachment 168812: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18086&attachment=168812) ----------------------------------------------------------------- ::: C4/Overdues.pm @@ +686,5 @@ > |); > + unless ( $branchcodes->[0] ) { > + my $default_rule = Koha::OverdueRules->search({ branchcode => undef > }, {})->next; > + if ($default_rule){ > + warn "default rule"; Is that a remaining debug statement from the development? ::: t/db_dependent/Overdues.t @@ +36,5 @@ > +$dbh->do(q| > + INSERT INTO branches ( branchcode, branchname ) VALUES > + ('CPL', 'foo'), > + ('MPL', 'bar') > +|); Might be worth using TestBuilder. Something like: $builder->build_object( { class => 'Koha::Libraries', value => { branchcode => 'CPL' } } ); -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
