https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18086
--- Comment #39 from Victor Grousset/tuxayo <[email protected]> --- Are there other tests relevant to run than t/db_dependent/Overdues.t ? Because a coverage analysis[1] shows that GetBranchcodesWithOverdueRules and GetOverdueMessageTransportTypes aren't executed during Overdues.t. [1] https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL17%3A_Unit_tests_are_required ---- The test plan lacks a step to update the DBIC schema files with the command "dbic" or equivalent. This causes the ORM to be out of sync with the database schema. --- The database upgrade fails when ran twice. kohadev-koha@kohadevbox:koha(testing-SO-QA)$ updatedatabase Upgrade to XXX [22:13:40]: Bug 18086 - Add FK constraints for branchcode and categorycode kohadev-koha@kohadevbox:koha(testing-SO-QA)$ updatedatabase C4::Installer::run_atomic_updates(): DBI Exception: DBD::mysql::db do failed: Can't create table `koha_kohadev`.`overduerules` (errno: 121 "Duplicate key on write or update") at /kohadevbox/koha/installer/data/mysql/updatedatabase.pl line 24309 DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_18086.perl [22:13:44] ERROR - C4::Installer::run_atomic_updates(): DBI Exception: DBD::mysql::db do failed: Can't create table `koha_kohadev`.`overduerules` (errno: 121 "Duplicate key on write or update") at /kohadevbox/koha/installer/data/mysql/updatedatabase.pl line 24309 Here is more info :) https://wiki.koha-community.org/wiki/Database_updates#Idempotent It's needed because such a change might be backported to a previous release of Koha. And then when doing the upgrade to the next release of Koha, part of the database migrations will be ran a second time because they would have been backported to the previous version and ran a first time. --- test plan: > 6) Editor should behave as it did before I forgot how that works, is the editor this page?: http://localhost:8081/cgi-bin/koha/tools/overduerules.pl --- Thanks a lot Baptiste for reviving this old and needed ticket :D -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
