https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36350
--- Comment #36 from Michał <[email protected]> --- (In reply to Julian Maurice from comment #35) > (In reply to David Gustafsson from comment #34) > > I am aware of this, and though the cache option in DBix is very poorly > > documented I think it's actually necessary [...] > This part worries me. > Using an obscure option because we /think/ it's necessary does not sound > like a good idea. We need to be sure that it's necessary and we need know > exactly what this option does. > > But even with that put aside, I'm skeptical about the implementation, in > particular the fact that the cache is managed at the Koha::Object(s) level. > If I read the flame graphs correctly, the bad performance was due to > Koha::Number::Format::Price::_format_params repeatedly fetching the active > currency. > Why not put the cache there ? It would be a lot simpler and safer, and would > allow for the same magnitude of performance boost. > > The patch also touches libraries, patrons, ILL requests and item types but > there is no evidence given that it does improve performance. Can you provide > some ? Very valid point, it seems that `Koha::Acquisition::Currencies->get_active` does a filter search on parent with `$self->SUPER::search( { active => 1 } )->next`, there's no index on `active` which probably doesn't help either, but the real problem is that this thing is probably called very many times. No full debugger html report was provided, meaning we don't see how many times the function was called. I think it'd be nice if Koha had some feature to actually dump the list of SQL queries being executed in the given request and the time it took to get a response for each, would make it easy to identify bottlenecks like this. And current currency definitely sounds like something that could be just cached in Memcached (and invalidate it when active one is being changed). -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
