https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557
--- Comment #236 from Jonathan Druart <[email protected]> --- (In reply to Olivia Reynolds from comment #235) > Thanks for taking a look at this Jonathan. This was pushed to main whilst I > was > on leave, so apologies for taking a few days to come back to you. > > > The batch edit/modification controls are too far from the table. We usually > > place the action buttons right above the table, using links (see the > > holdings > > tables). > > Originally this bug introduced an additionalButtons option to place buttons > in > the table header using DataTable's support for this. Later on in response to > feedback I chose to move these to the toolbar. I do want to keep the number > of > core DataTable/KohaTable changes made here as low as possible. I would like Owen's opinion on this one, but to me having the actions for the selection in the toolbar is not what we usually do. On the checkout list we have button at the bottom of the table: https://snipboard.io/gVilZc.jpg On the holdings table with action links at the top of the table: https://snipboard.io/8sndtZ.jpg We are introducing a third version here. > > `Something went wrong: Error: Unrecognised barcodes: bc_1` > > I'm afraid I can't reproduce this. The only idea I have is that the barcodes > in > this API call are passed through barcodedecode - could that be having an > effect > in your configuration? Found the cause: It's "BC_1" in DB but "bc_1" is accepted everywhere else (checkout, checkin, etc.) > > I18N: > > > > Koha/REST/V1/Item/Lists.pm: error => 'Sharee is the list owner', > > Looking through the other REST controllers, including those for Vue > resources, > it doesn't look like we have translated these previously. Do you know an > example > I can look at where they have been? Hum indeed, that's odd that we don't have such pattern existing already for Vue components. We are supposed to send an error_code and translate it into a proper error message on the UI. > > Did we upgrade DataTables to a major version then? This shouldn't be done > > hidden in a big pachset, but properly advertised on a separate bug report > > (what > > we always do), to provide regression testing. Also it means that now Vue and > > non-Vue tables are no longer using the same version. > > I tried to be very careful around upgrading dependencies. Looking at the > patches, I think this does bump DataTables from 2.3.7 to 2.3.8, as I was > unable > to get 2.3.7 from the DataTables CDN at the time. I think this may be > possible > now, so I can look at reverting that upgrade? I am sorry, I had messed up with my ktd it seems. I might had a stale node_modules or something, because I do not longer recreate the error. This error confused me: `Error: Select requires DataTables 3.1 or newer`. But I have no idea how I did that! I don't think the minor upgrade is important, but keep in mind that they usually should be isolated on their own bug report. Are you going to work/answer the other comments? :) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
