https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557
--- Comment #235 from Olivia Reynolds <[email protected]> --- Thanks for taking a look at this Jonathan. This was pushed to main whilst I was on leave, so apologies for taking a few days to come back to you. > The batch edit/modification controls are too far from the table. We usually > place the action buttons right above the table, using links (see the holdings > tables). Originally this bug introduced an additionalButtons option to place buttons in the table header using DataTable's support for this. Later on in response to feedback I chose to move these to the toolbar. I do want to keep the number of core DataTable/KohaTable changes made here as low as possible. > `Something went wrong: Error: Unrecognised barcodes: bc_1` I'm afraid I can't reproduce this. The only idea I have is that the barcodes in this API call are passed through barcodedecode - could that be having an effect in your configuration? > I18N: > > Koha/REST/V1/Item/Lists.pm: error => 'Sharee is the list owner', Looking through the other REST controllers, including those for Vue resources, it doesn't look like we have translated these previously. Do you know an example I can look at where they have been? > Did we upgrade DataTables to a major version then? This shouldn't be done > hidden in a big pachset, but properly advertised on a separate bug report > (what > we always do), to provide regression testing. Also it means that now Vue and > non-Vue tables are no longer using the same version. I tried to be very careful around upgrading dependencies. Looking at the patches, I think this does bump DataTables from 2.3.7 to 2.3.8, as I was unable to get 2.3.7 from the DataTables CDN at the time. I think this may be possible now, so I can look at reverting that upgrade? In general on this bug I tried to order all of the core Koha changes first so they could be reviewed in isolation, rather than smearing them as they were required for new features in the latter patches. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
