Hi Nigel, That's looking good to me. When you're ready with a patch, you can use "git bz" in koha-testing-docker to upload the patch to https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34527 and then testers and QA will take it from there.
Joubu (Jonathan Druart) has a lot of work to do, so I'm sure he wouldn't mind you working on this! Being familiar with the original code, you might find he comments on the patch/report at some stage. David Cook Senior Software Engineer Prosentient Systems Suite 7.03 6a Glen St Milsons Point NSW 2061 Australia Office: 02 9212 0899 Online: 02 8005 0595 -----Original Message----- From: Nigel Titley <ni...@titley.com> Sent: Monday, 14 August 2023 9:40 PM To: David Cook <dc...@prosentient.com.au>; koha-devel@lists.koha-community.org Subject: Re: [Koha-devel] [Koha] Where would I put the OpenLibrary ID in the MARC record Hi David Many thanks. I've read the documentation, created a koha bugzilla account, created an enhancement request and assigned to myself, just to kick this off. However, looks like the original author of the OpenLibrary cover retrieval code (joubu) is still around so they may be better equipped than me to deal with this. I don't want to tread on anyone's toes. If this isn't the right process then please let me know. All the best and thanks to the wonderful koha community for being so helpful. Nigel On 14/08/2023 02:18, David Cook wrote: > Hi Nigel, > > "I'm going to do this in a docker container" is what I say for most of my > code projects (at home and the office). So long as you're not working with > SystemD, it generally makes everything easier. > > I think this wiki page might describe the process best: > https://wiki.koha-community.org/wiki/Development_workflow > > And for the practical aspect of submitting the patch, you'll want to > look at https://wiki.koha-community.org/wiki/Git_bz_configuration > > Let us know if you have any issues. > > Once your patch is accepted, you'll also join this list: > https://git.koha-community.org/stats/koha-master/authors.html > > David Cook > Senior Software Engineer > Prosentient Systems > Suite 7.03 > 6a Glen St > Milsons Point NSW 2061 > Australia > > Office: 02 9212 0899 > Online: 02 8005 0595 > > -----Original Message----- > From: Nigel Titley <ni...@titley.com> > Sent: Friday, 11 August 2023 8:01 PM > To: David Cook <dc...@prosentient.com.au>; > koha-devel@lists.koha-community.org > Subject: Re: [Koha-devel] [Koha] Where would I put the OpenLibrary ID > in the MARC record > > And that, as if by magic, answers what was to be my next question... the > koha-testing-docker instructions look comprehensive and I can try them out on > my desktop, which seems to meet the requirements. My son, when I was > discussing the project with him, said "you should do this in a docker > container" and as usual he was right. > > I presume that once/if I've got it working there's a submission process to > get updates back to the main Koha branch. > > All the best > > Nigel > > On 11/08/2023 00:07, David Cook wrote: >> That's great news, Nigel! I'm really happy that worked out. >> >> Have you looked at koha-testing-docker? >> https://gitlab.com/koha-community/koha-testing-docker >> >> You could do the development work on there and then wait/hope for it to flow >> down to your version? >> >> David Cook >> Senior Software Engineer >> Prosentient Systems >> Suite 7.03 >> 6a Glen St >> Milsons Point NSW 2061 >> Australia >> >> Office: 02 9212 0899 >> Online: 02 8005 0595 >> >> -----Original Message----- >> From: Koha-devel <koha-devel-boun...@lists.koha-community.org> On >> Behalf Of Nigel Titley >> Sent: Thursday, 10 August 2023 6:40 PM >> To: koha-devel@lists.koha-community.org >> Subject: Re: [Koha-devel] [Koha] Where would I put the OpenLibrary ID >> in the MARC record >> >> >> >> On 08/08/2023 10:58, Nigel Titley wrote: >>> >>> >>> On 24/07/2023 01:11, David Cook wrote: >>> >>>> You could send a request for an "openlibrary" code to be added to >>>> the official Standard Identifier Source Codes list: >>>> https://www.loc.gov/standards/sourcelist/index.html#maintenance . >>>> Honestly, I'm a little surprised there isn't already an entry for >>>> it there. I'm sure they'd approve a request for it. >>> >>> I've put in a request to the LOC. We'll see if anything comes of it. >>> They may request (I would do so in their place) that the request >>> comes from the Open Library itself in which case I'll have to chase >>> that route first. >> >> Well, to my surprise LOC got back to me today and said they had added Open >> Library to the SISC list. >> >> https://loc.gov/marc/relators/tn230808src.html >> >> So we now have a standardised way to add OLIDs to a MARC record >> >> 024 7 _ | $2 openlib | $a <OLID> >> >> And that means I can have a look at adding OLIDs to the cover art retrieval >> from Open Library... which means dusting off my... erk... >> javascript. Which means sorting out sympa so I can get Koha up to date... >> >> Nigel >> _______________________________________________ >> Koha-devel mailing list >> Koha-devel@lists.koha-community.org >> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel >> website : https://www.koha-community.org/ git : >> https://git.koha-community.org/ bugs : >> https://bugs.koha-community.org/ >> > _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : https://www.koha-community.org/ git : https://git.koha-community.org/ bugs : https://bugs.koha-community.org/
