> > That's not checked into the tree; I think that comes from the build > > environment itself. > > Right... but who or what sets the matching flag in the build ?
The build uses the value of the VERSION environment variable, if it's set. As per $SRC/tools/env/*.sh, this is usually set to the name of the workspace being built. I presume that whoever spun that build set VERSION to snv_<build> in their env file. > > A number of things under usr/src/tools are aware of RELEASE -- and > > probably a lot of other stuff that's been built over the years. > > Is there a way to hunt down all consumers of RELEASE ? I can't see how. Unless you just like pain, I'd leave things be. > > > Is there any rule against global, single-word Makefile variables with > > > less then four letters in the Makefile style guide yet ? > > > > No :-) > > Should I file a bug/RFE to get something like that added (e.g. "...any > variable added to an OS/Net Makefile which is visible/used by multiple > makefiles should be named using more than one word and have at least > four characters..." or something like that (that still misses things > like "namespaces" etc.)) ? You could, but it will probably sit there as AFAIK no one is maintaining that Makefile style guide (I still have some changes from several years ago that never made it back). > > > +# common CPP flags for libshell consumers (ksh, shcomp etc.) > > > > I thought shcomp wasn't part of this putback? > > Uhm...right... > ... but technically only the Makefiles are missing But that's the only part that matters as far as that comment is concerned. -- meem
