IA64 doesn't need it as well. OK, keep them under arch, but we have to expose 
kvm_lock, and vm_list out. :)
Xiantao

-----Original Message-----
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Carsten Otte
Sent: 2007年11月14日 19:53
To: Zhang, Xiantao
Cc: [email protected]; [EMAIL PROTECTED]; Hollis Blanchard; Avi 
Kivity
Subject: Re: [kvm-devel] [PATCH] 3/5 Using kvm arch support instead 
ofkvm_x86_ops

I still do strongly agree with the general idea of this patch, and 
most of the split comes out just right now. However, there is one 
thing I'd like to pick on:

decache_vcpus_on_cpu should be an arch callback, and rather than 
kvm_arch_vcpu_decache. There's no reason for s390 to grab locks and do 
the arch callback in a loop. The whole thing is nop for us, thus the 
whole thing should be a callback.

I'd really like to see this changed before the patch gets merged.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
kvm-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Attachment: 0005-Move-some-x86-specific-part-from-kvm_init-to-kvm_arc.patch
Description: 0005-Move-some-x86-specific-part-from-kvm_init-to-kvm_arc.patch

Attachment: 0001-Move-some-includes-to-x86.c-from-kvm_main.c-since-t.patch
Description: 0001-Move-some-includes-to-x86.c-from-kvm_main.c-since-t.patch

Attachment: 0002-move-kvm_x86_ops-to-x86.c.patch
Description: 0002-move-kvm_x86_ops-to-x86.c.patch

Attachment: 0003-Using-kvm-arch-support-to-replace-kvm_x86_ops-and-f.patch
Description: 0003-Using-kvm-arch-support-to-replace-kvm_x86_ops-and-f.patch

Attachment: 0004-Combine-kvm_init-and-kvm_init_x86-and-will-be-calle.patch
Description: 0004-Combine-kvm_init-and-kvm_init_x86-and-will-be-calle.patch

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
kvm-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Reply via email to