On 2013-09-21 19:26, Jaume Ortolà i Font wrote: Hi Jaume,
> This issue is solved now. thanks! Here are some minor comments on your patch: -In general, we should keep our API stable, as other developers will rely on it in the future (especially now that it's easy to use LT from Maven Central). So instead of removing/renaming public methods, we should keep the old one and deprecate it. Maybe that's not practical here, in that case please add a comment in CHANGES.txt. -New public methods should have a @since tag -Should getVariant() maybe return null by default, i.e. if it's not overwritten? That seems a bit more natural than the empty string. -The string "qlt" should probably be a constant with a more verbose name Regards Daniel -- http://www.danielnaber.de ------------------------------------------------------------------------------ LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99! 1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/22/13. http://pubads.g.doubleclick.net/gampad/clk?id=64545871&iu=/4140/ostg.clktrk _______________________________________________ Languagetool-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/languagetool-devel
