On Sun, Aug 23, 2015 at 11:50 AM, 'Terry Brown' via leo-editor < [email protected]> wrote:
> There's now an "Edit settings" menu under the main Settings menu. > Thanks Terry. This is a step forward for everyone, including newbies. It's not going to make everyone (anyone?) happy, you still have to edit > the content of a Leo headline to change font size etc. The new > functionality is that it finds the appropriate setting and copies it to > the appropriate outline for you, so knowing what to look for and how to > manage it is handled. > I think that's useful. > > Sometimes you'll see this: > > The relevant setting, '@bookmarks_base_color', is using the value of > a more general setting, '@text-foreground'. Would you like to edit > the more specific setting, '@bookmarks_base_color', or the more > general setting, '@text-foreground'? The more general setting may > alter appearance / behavior in more places, which may or may not be > what you prefer. > > Edit specific Edit general Cancel > > Wordy, but I think easy enough to follow. I guess everything after the > last comma could be deleted :-) > > If the setting is in leoSettings.leo, you see: > > The setting '@body-font-family' is in the Leo global configuration > file 'leoSettings.leo' and should probably be copied to > 'myLeoSettings.leo' before editing. > It may make more sense to copy a group or category of settings. > > Please enter 1, 2, 3, or 4: > 1. copy the one setting, '@body-font-family' > 2. copy the setting group, 'Body font' (Recommended) > 3. copy the setting whole category, 'Fonts' > 4. edit the setting in 'leoSettings.leo' anyway > > Again, wordy, but I think easy enough to understand. > I agree. And even if the user hits "cancel", they now have know what's available and where. Note "Reload settings" isn't working as effectively as I think it > should, that may need to be addressed as well. Unrelated to the new > code. > Reload settings is going to be a project, for several reasons. Many classes cache settings so they don't have to keep calling c.config.getX. This is/was purely an abbreviation, but caching a setting means that it's impossible to change the setting. Going through the code an replacing the abbreviations with "dynamic" calls to c.config.getX isn't rocked science, it's merely tedious and perhaps error prone. > So, this isn't a silver bullet for the newbie setting editing woes, but > it does eliminate a lot of the Leo specific knowledge required (apart > from "edit a headline"). Also this new approach can be developed > further based on feedback, just wanted to get what I had so far into > the main branch for testing etc. > I approve. It's a reasonable middle ground. Imo, it's better than .ini files (not Leonine) or gui-based ways to change settings. 5 or 10 years ago I played around with such a thing. It will never be a good idea. Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/leo-editor. For more options, visit https://groups.google.com/d/optout.
