On 09/10/2018 04:23 AM, Pierre Labastie wrote:
On 9/9/18 7:23 PM, Bruce Dubbs wrote:
On 09/09/2018 01:04 AM, Kevin Buckley wrote:
A small thing I noticed, when using the "dump-commands" target
from the Book's SVN repo, was that in

    4.5 About SBUs

the two example commands in the following

    For instance, a Core2Duo can support two simultaneous processes with:

    export MAKEFLAGS='-j 2'

    or just building with:

    make -j2


appear in the output when one does a

make dump-commands

As far as I know, that target is no longer used.  Just ignore it.
We will leave it alone though in case we want to resurrect it at some time in the future.

Well, the Makefile is broken for this target, because it uses $(RENDERTMP)/lfs-html.xml, but the generation of this file has been commented out. The simple fix is to replace $(RENDERTMP)/lfs-html.xml with $(RENDERTMP)/lfs-full.xml.

Note that I amazed "make dump-commands" did not fail completely. It did for me, and this is the expected behavior...

Then the file stylesheets/dump-commands.xsl should be replaced with the one from the blfs repo (well, note quite, it needs some editing too).

I can do that, unless there is a strong opposition...

Still, the examples in About SBU's should be made similar to the others in the book (that is removing <userinput> tags, or add role="nodump").

I have no problem with you making those changes, but will raise the issue of whether the dump-commands is useful at all. Why not just remove the dump-commands target from the Makefile?

Adding role="nodump" is fine in any case to make things consistent.

  -- Bruce

--
http://lists.linuxfromscratch.org/listinfo/lfs-dev
FAQ: http://www.linuxfromscratch.org/faq/
Unsubscribe: See the above information page

Reply via email to