On 11 September 2018 at 00:38, Bruce Dubbs <[email protected]> wrote:
>>> As far as I know, that target is no longer used. Just ignore it. >>> We will leave it alone though in case we want to resurrect it at some >>> time in the future. >>> >> Well, the Makefile is broken for this target, because it uses >> $(RENDERTMP)/lfs-html.xml, but the generation of this file has been >> commented out. The simple fix is to replace $(RENDERTMP)/lfs-html.xml with >> $(RENDERTMP)/lfs-full.xml. >> >> Note that I amazed "make dump-commands" did not fail completely. It did >> for me, and this is the expected behavior... >> >> Then the file stylesheets/dump-commands.xsl should be replaced with the >> one from the blfs repo (well, note quite, it needs some editing too). >> >> I can do that, unless there is a strong opposition... >> >> Still, the examples in About SBU's should be made similar to the others in >> the book (that is removing <userinput> tags, or add role="nodump"). > > > I have no problem with you making those changes, but will raise the issue of > whether the dump-commands is useful at all. Why not just remove the > dump-commands target from the Makefile? But it seems to do exactly what its name suggests it should, if run as part of the "all:" target. Indeed, I have been comparing it's output with the commands I ran for an 8.0 LFS build, that I had saved by hand (so as to add extra XML into my local copy of the 8.3 Book), and, give or take a few expected differences, it's a match. If anything the "dump-commands" target is a useful test of whether the "examples" and "real commands" are marked up correctly, no ? -- http://lists.linuxfromscratch.org/listinfo/lfs-dev FAQ: http://www.linuxfromscratch.org/faq/ Unsubscribe: See the above information page
