Andrea Crotti <[email protected]> writes: > Diego Biurrun <[email protected]> writes: > >> >> Not hard, but pointless, because it defeats the purpose of this endeavor, >> which is making emacs behave correctly out-of-the-box. The operative >> word here is "out-of-the-box". >> >> We do have a coding style, but far too often during reviews we have to >> point that style out to people, especially newcomers. This is because >> >> a) the style is underdocumented and >> b) it is too easy to mess up. >> >> I will address a) once I'm done with the spring cleanup. Luckily >> Andrea has stepped up and contributed towards fixing b). Let's not >> make getting contributions accepted harder than it already is, this >> is going in the right direction. >> >> If the emacs defaults have to be set manually, then we will have to >> keep telling people "Oh, you should have put that file from tools/ >> in the top-level directory, now please redo your patch.", but we >> don't want that, we want them to get it right from the start. >> >> Diego > > +1. > > Moreover there is one other thing which I think is to note. The > impression I get from some comments is that the libav community should > be closed to the few aficionados, which know all the bureaucratic things > that have to be done to participate in the project.
The rules are simple: if several core developers say they dislike your patch, you should FUCKING DROP IT. If you continue pushing for this, I will dislike not only your patch but YOU as well. > There are outside many developers that would contribute with a couple of > patches a year, and maybe they do the same on 15 different projects. > > These 15 different projects all use (of course) different coding styles > and policies. It would be nice if instead of trying to figure out in > some hidden documentation what is the desired style for this and that at > least for the emacs/vi users would work automatically. If a project makes me jump through hoops to prevent automatic overrides of _my_ carefully tuned editor settings, that's one project I won't be contributing to. > These default settings would also not break anything as far as I know > (or I would be glad to see a counterexample), and would avoid annoying > things like: I have lots of specific settings already configured based on file path. This would override or interfere with them. Put the files in tools/ and let those who wish to use them symlink them into the libav root dir. People unable to do that are probably unable to contribute anything meaningful anyway. Sobbing about this being the only contribution you were able to make will not win anyone's hearts here. People simply don't like your patch, so suck it up. -- Måns Rullgård [email protected] _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
