weekly ping :)
as I explained in the first email this patch is not doing the right thing as the "right thing"(tm) would be to actually crop the resulting frame to the dimensions specified in the cropping rectangle (tested on the JM); however this patch takes a saner approach for the current handling in which the "unusual" cropping values are always ignored and don't modify the final resolution.

Vittorio

On 09/05/2011 23:23, Ronald S. Bultje wrote:
Hi,

On Mon, May 9, 2011 at 9:48 AM, Diego Biurrun<di...@biurrun.de>  wrote:
On Mon, May 09, 2011 at 03:43:39PM +0200, Diego Biurrun wrote:
On Thu, May 05, 2011 at 10:16:43PM +0200, Luca Barbato wrote:
On 05/05/2011 05:49 PM, Vittorio Giovara wrote:
ping!
No more comments means the patch is ok and can be committed, right? :)
Yes, but sadly I had been busy so I could try it properly nor run fate
over it. If somebody has time to push please do ^^;
Queued.
.. and unqueued again, this breaks FATE ..

biurrun@passion:~/src/priv/libav $ make fate-h264-interlace-crop
TEST    h264-interlace-crop
--- /home/biurrun/src/priv/libav/tests/ref/fate/h264-interlace-crop     
2011-04-22 23:34:08.386459064 +0200
+++ tests/data/fate/h264-interlace-crop 2011-05-09 15:47:12.090775254 +0200
@@ -1,3 +1,3 @@
-0, 0, 345600, 0xa9cb7e5a
-0, 3600, 345600, 0x73e47555
-0, 7200, 345600, 0x87aac593
+0, 0, 360960, 0xd8a6a4fa
+0, 3600, 360960, 0x8d67a867
+0, 7200, 360960, 0x460fff31
make: *** [fate-h264-interlace-crop] Error 1

Vittorio, please try to use git-send-email, your mime-encoded patches
are unnecessarily hard to apply.
And please revise your patch to pass FATE :)
Check that the patch is now doing the right thing, e.g. by comparing
it to JM output or so.

Ronald
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to