On Sun, 31 Jul 2011 14:53:43 +0800, Yu-Jie Lin <[email protected]> wrote: > On Sun, Jul 31, 2011 at 14:25, Anton Khirnov <[email protected]> wrote: > > > > On Sun, 31 Jul 2011 14:06:02 +0800, Yu-Jie Lin <[email protected]> wrote: > >> "-show_region 1" actually looks weird if considering from the > >> perspective of a normal user. > >> > >> However, I still want to keep it as "1" or at least some common > >> understandable name in libav (which I don't know if any other already > >> have) like > > > > 1 is fine for now. You can always add named constants later if there's a > > reason for it. > > Then, 1 is. > > And an updated patch attached. > From 5249178dd6703dbc83cebc8cf9721e251266d51a Mon Sep 17 00:00:00 2001 > From: Yu-Jie Lin <[email protected]> > Date: Sat, 30 Jul 2011 19:13:43 +0800 > Subject: [PATCH 2/2] x11grab: add show_region AVOption. > > Draw the current grabbing region for indication. > > Signed-off-by: Yu-Jie Lin <[email protected]> > --- > doc/ffmpeg.texi | 13 +++++++ > doc/indevs.texi | 19 +++++++++++ > libavdevice/x11grab.c | 87 > +++++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 119 insertions(+), 0 deletions(-) >
Ok. Both pushed. -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
