On 18/02/13 21:04, Reinhard Tartler wrote:

I'm not sure it is _that_ compelling.

> +                           NB: Cannot be combined with --target-exec.

This line could go in the documentation (malloc-fill is debatable btw)
but we shouldn't force this, it makes the whole feature less useful.

> +   target_exec="${valgrind##--} --malloc-fill=0x2a --track-origins=yes 
> --leak-check=full --gen-suppressions=all 
> --suppressions=$source_path/tests/fate-valgrind.supp"


This is useful and should be part of the documentation, not of the tests.

> diff --git a/tests/fate-valgrind.supp b/tests/fate-valgrind.supp
> new file mode 100644
> index 0000000..db72c54
> --- /dev/null
> +++ b/tests/fate-valgrind.supp

I'd consider the whole thing a bit more.

lu
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to