On Mon, Feb 18, 2013 at 10:50 PM, Luca Barbato <[email protected]> wrote:
> On 18/02/13 21:04, Reinhard Tartler wrote:
>
> I'm not sure it is _that_ compelling.
>
>> + NB: Cannot be combined with --target-exec.
>
> This line could go in the documentation (malloc-fill is debatable btw)
> but we shouldn't force this, it makes the whole feature less useful.
I'm not sure if I grasp your review in full. I understand that you
object to having that line in the configure output, but suggest to
place it somewhere in doc/developer.texi instead. Is this correct?
>
>> + target_exec="${valgrind##--} --malloc-fill=0x2a --track-origins=yes
>> --leak-check=full --gen-suppressions=all
>> --suppressions=$source_path/tests/fate-valgrind.supp"
>
>
> This is useful and should be part of the documentation, not of the tests.
I don't understand this comment. I do not propose to have it as part
of the test-suite, but as a convenience configure-switch that sets
--target-exec for use with valgrind. Do you object to this idea? If
yes, please elaborate why, so that I can propose a wording to
doc/developer.texi that addresses your objection.
>> diff --git a/tests/fate-valgrind.supp b/tests/fate-valgrind.supp
>> new file mode 100644
>> index 0000000..db72c54
>> --- /dev/null
>> +++ b/tests/fate-valgrind.supp
>
> I'd consider the whole thing a bit more.
I'm also unsure what you mean with this. Should this be committed
separately? Or do you object to having it in libav.git at all? If yes,
why?
Or do you request additional time for thinking about this a bit more?
--
regards,
Reinhard
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
