On Sun, Mar 17, 2013 at 07:59:35AM +0100, Reinhard Tartler wrote:
>
> --- a/configure
> +++ b/configure
> @@ -2155,6 +2155,10 @@ case "$toolchain" in
> add_cflags -fthread-sanitizer
> add_ldflags -fthread-sanitizer
> ;;
> + valgrind-memcheck)
That valgrind is a memory checker is well-known. I would prefer a name
that suggests more of a combination with FATE, which is what the option
does, such as "fate-valgrind" or "valgrind-fate" or just plain "valgrind".
> + target_exec_default="valgrind"
> + target_exec_args="--track-origins=yes --leak-check=full
> --suppressions=$source_path/tests/fate-valgrind.supp"
> + ;;
> msvc)
> cc_default="c99wrap cl"
> ld_default="c99wrap link"
> @@ -3959,7 +3963,7 @@ HOSTCC_DEPFLAGS=$HOSTCC_DEPFLAGS
> HOSTCC_O=$HOSTCC_O
> HOSTLD_O=$HOSTLD_O
> -TARGET_EXEC=$target_exec
> +TARGET_EXEC=$target_exec $target_exec_args
> TARGET_PATH=$target_path
Why not just add the args to target_exec?
> @@ -2167,7 +2171,7 @@ case "$toolchain" in
>
> -set_default arch cc pkg_config sysinclude target_os
> +set_default arch cc pkg_config sysinclude target_os target_exec
order
> diff --git a/doc/developer.texi b/doc/developer.texi
> index 1a87859..e9a6e7f 100644
> --- a/doc/developer.texi
> +++ b/doc/developer.texi
> @@ -547,6 +547,14 @@ why the expected result changed.
>
> Please refer to @url{fate.html}.
>
> +@subsection Using Valgrind
> +
> +The configure script provides a shortcut for using valgrind to spot bugs
> +related to memory handling. Just add the option
> +@code{--toolchain=valgrind-memcheck} to your configure line, and
> +reasonable defaults will be set for running FATE under the supervision
> +of the @strong{memcheck} tool of the valgrind suite.
It would seem that fate.texi is a better location for this note.
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
