On Thu, 18 Jul 2013, Martin Storsjö wrote:
On Thu, 18 Jul 2013, Diego Biurrun wrote:
---
Due to popular demand, now w/o renaming the rsync target.
tests/Makefile | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/Makefile b/tests/Makefile
index e32320d..cd0d426 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -24,7 +24,10 @@ tests/data/filtergraphs/%: TAG = COPY
tests/data/filtergraphs/%: $(SRC_PATH)/tests/filtergraphs/% |
tests/data/filtergraphs
$(M)cp $< $@
+# Check sanity of dependencies when running FATE tests.
+ifneq (,$(filter check fate $(FATE),$(MAKECMDGOALS)))
CHKCFG = $(if $($(1))$(!$(1)),$($(1)), $(error No such config: $(1)))
+endif
I'm not sure why, but on make 3.81, this breaks calling individual fate
tests. "make fate-aac" gives "make: Nothing to be done for `fate-aac'." and
"make fate-aac-al04_44" gives "make: *** No rule to make target
`fate-aac-al04_44'. Stop.".
This is probably because the FATE env variable is empty at this
point. Also, even if the FATE variable would be fully populated here, not
all of the intermediate groups (such as fate-aac) would be added to it
necessarily I think - only the individual tests themselves are added there
(at least for aac).
If there are cases which this pattern doesn't match, we need to add an
else branch containing CHKCFG=$(1).
Alternatively, match fate% as you did initially and just filter out
fate-rsync. Yes, ugly, but would work.
// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
