On Sat, May 03, 2014 at 07:20:24PM +0200, Janne Grunau wrote:
> Instead of setting FFLIBS in each library Makefile configure
> exports $LIBNAME_FFLIBS in config.mak.
> ---
> common.mak | 2 +-
> configure | 55
> +++++++++++++++++++++++++++++++++++---------------
> libavcodec/Makefile | 1 -
> libavdevice/Makefile | 1 -
> libavfilter/Makefile | 5 -----
> libavformat/Makefile | 1 -
> libavresample/Makefile | 1 -
> libswscale/Makefile | 1 -
> 8 files changed, 40 insertions(+), 27 deletions(-)
Looks decent in general.
> --- a/configure
> +++ b/configure
> @@ -655,6 +655,16 @@ prepend(){
>
> +unique(){
> + varname=$1
> + uniq_list=""
> + for tok in $(eval echo \$$var); do
s/var/varname/?
> + uniq_list="$(filter_out $tok $uniq_list) $tok"
> + done
> + eval "$varname=\"${uniq_list# }\""
> + unset uniq_list
> +}
Why do you unset the variable?
> @@ -4572,6 +4595,7 @@ get_version(){
> eval echo "${lcname}_VERSION=\$${name}_VERSION" >> config.mak
> eval echo "${lcname}_VERSION_MAJOR=\$${name}_VERSION_MAJOR" >> config.mak
> eval echo "${lcname}_VERSION_MINOR=\$${name}_VERSION_MINOR" >> config.mak
> + eval echo "${1}_FFLIBS=\$${1}_deps" >> config.mak
> }
This does not really belong in a function called get_version().
> @@ -4655,7 +4683,7 @@ includedir=$incdir
> Name: $name
> Description: $comment
> Version: $version
> -Requires: $(enabled shared || echo $requires)
> +Requires: $(enabled shared || echo ${requires%,})
> Requires.private: $(enabled shared && echo $requires)
This seems odd, if $requires contains a trailing comma, why only filter
it out in this place?
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
