On 2014-05-13 00:59:14 +0200, Diego Biurrun wrote:
> On Thu, May 08, 2014 at 11:27:07PM +0200, Janne Grunau wrote:
> > On 2014-05-08 17:23:26 +0200, Diego Biurrun wrote:
> > > On Sat, May 03, 2014 at 07:20:24PM +0200, Janne Grunau wrote:
> > --- a/configure
> > +++ b/configure
> > @@ -655,6 +655,15 @@ prepend(){
> > +unique(){
> > + var=$1
> > + uniq_list=""
> > + for tok in $(eval echo \$$var); do
> > + uniq_list="$(filter_out $tok $uniq_list) $tok"
> > + done
> > + eval "$var=\"${uniq_list# }\""
> > +}
>
> Do you really need to eliminate the starting space?
I don't think so
> > @@ -4371,6 +4380,19 @@ for thread in $THREADS_LIST; do
> > +
> > +expand_deps(){
> > + eval "deps=\$${1}_deps"
> > + append ${1}_deps $(map 'eval echo \$${v}_deps' $deps)
> > + unique ${1}_deps
> > +}
>
> Maybe add a variable for ${1}_deps.
>
> > @@ -4671,22 +4700,17 @@ includedir=${source_path}
> > Name: $name
> > Description: $comment
> > Version: $version
> > -Requires: $requires
> > +Requires: $(echo $requires)
>
> Huh?
$requires is newline separated and pkg-config doesn't like that (tested it),
if you have better ideas how to remove the newlines or even better create
$requires space separated would be welcome. I guess using printf instead of
echo in lib_version would work.
Janne
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
