On Tue, May 13, 2014 at 11:55:38AM +0200, Janne Grunau wrote:
> --- a/configure
> +++ b/configure
> @@ -655,6 +655,15 @@ prepend(){
>
> +unique(){
> + var=$1
> + uniq_list=""
> + for tok in $(eval echo \$$var); do
Do you need the echo?
> + uniq_list="$(filter_out $tok $uniq_list) $tok"
> + done
> + eval "$var=\"${uniq_list}\""
> +}
The empty initialization of uniq_list seems pointless.
> @@ -4373,6 +4382,20 @@ for thread in $THREADS_LIST; do
> +expand_deps(){
> + lib_deps=$1_deps
Make this ${1}_deps to be safe.
> @@ -4639,13 +4664,18 @@ test -n "$WARNINGS" && printf "\n$WARNINGS"
> pkgconfig_generate(){
> name=$1
> shortname=${name#lib}${build_suffix}
> comment=$2
> version=$3
> libs=$4
> - requires=$5
> + requires=$(map 'lib_version $v' $(eval echo \$${name#lib}_deps))
> + requires=${requires%, }
> enabled ${name#lib} || return 0
${name#lib} is used in multiple places. Time to add a variable for it.
Or maybe we should just drop the build_suffix nonsense.
LGTM otherwise
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
