On 2014-05-13 19:28:24 +0200, Diego Biurrun wrote:
> On Tue, May 13, 2014 at 11:55:38AM +0200, Janne Grunau wrote:
> > --- a/configure
> > +++ b/configure
> > @@ -655,6 +655,15 @@ prepend(){
> >
> > +unique(){
> > + var=$1
> > + uniq_list=""
> > + for tok in $(eval echo \$$var); do
>
> Do you need the echo?
yes, or is there another way of getting the contents of the variable with
the name in $var as list in the for
> > + uniq_list="$(filter_out $tok $uniq_list) $tok"
> > + done
> > + eval "$var=\"${uniq_list}\""
> > +}
>
> The empty initialization of uniq_list seems pointless.
it clears the values from the last unique call. I can add a comment or
change it to unset at the end of the function with comment.
> > @@ -4373,6 +4382,20 @@ for thread in $THREADS_LIST; do
> > +expand_deps(){
> > + lib_deps=$1_deps
>
> Make this ${1}_deps to be safe.
done
> > @@ -4639,13 +4664,18 @@ test -n "$WARNINGS" && printf "\n$WARNINGS"
> > pkgconfig_generate(){
> > name=$1
> > shortname=${name#lib}${build_suffix}
> > comment=$2
> > version=$3
> > libs=$4
> > - requires=$5
> > + requires=$(map 'lib_version $v' $(eval echo \$${name#lib}_deps))
> > + requires=${requires%, }
> > enabled ${name#lib} || return 0
>
> ${name#lib} is used in multiple places. Time to add a variable for it.
> Or maybe we should just drop the build_suffix nonsense.
can we postpone that to the pkg-config from make cleanup? It's on my todo
list.
Janne
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
