On Mon, Nov 21, 2016 at 12:31:24AM +0100, Janne Grunau wrote:
> --- a/configure
> +++ b/configure
> @@ -348,9 +348,8 @@ Developer options (useful when working on Libav itself):
> - --ignore-tests=TESTS whitespace-separated list (without "fate-" prefix
> - in the name) of tests not to run as part of the
> - fate target
> + --ignore-tests=TESTS comma-separated list (without "fate-" prefix
> + in the name) of tests which result is ignored
whose result
Why comma-separated instead of whitespace-separated?
> @@ -5217,6 +5216,7 @@ for type in decoder encoder hwaccel parser demuxer
> muxer protocol filter bsf ind
>
> if test -n "$ignore_tests"; then
> + ignore_tests=$(echo $ignore_tests | tr ',' ' ')
You manually whitespace-separate the list of tests here ..
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -143,11 +143,17 @@ endif
>
> -fate: $(filter-out $(addprefix fate-,$(IGNORE_TESTS)),$(FATE))
> +define FATE_IGNORE
> +fate-$(1): REPORT=ignore
> +endef
> +
> +$(foreach I,$(IGNORE_TESTS),$(eval $(call FATE_IGNORE,$(I))))
$(FATE_IGNORE): REPORT=ignore
> --- a/tests/fate-run.sh
> +++ b/tests/fate-run.sh
> @@ -212,13 +213,16 @@ if test -e "$ref" || test $cmp = "oneline" ; then
> esac
> cmperr=$?
> test $err = 0 && err=$cmperr
> - test $err = 0 || cat $cmpfile
> + case $report_type in
> + ignore) test $err = 0 || echo "ignoring fate-${test}" && err=0 ;;
> + *) test $err = 0 || cat $cmpfile ;;
> + esac
Do you plan to add more cases here? Otherwise a simple if-check seems
simpler. Not a big deal of course...
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
