On 2016-10-21 21:39:56 +0200, Diego Biurrun wrote:
> This can be useful to filter out noise in known-broken scenarios like
> miscompilation by legacy compilers and similar.
> ---
>
> Applied suggestions by Janne and added config file support.
>
> configure | 10 ++++++++++
> doc/fate.texi | 1 +
> tests/Makefile | 4 +++-
> tests/fate.sh | 1 +
> 4 files changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 9b24a91..f31792f 100755
> --- a/configure
> +++ b/configure
> @@ -347,6 +347,8 @@ Developer options (useful when working on Libav itself):
> --random-seed=VALUE seed value for --enable/disable-random
> --disable-valgrind-backtrace do not print a backtrace under Valgrind
> (only applies to --disable-optimizations builds)
> + --ignore-tests=TESTS whitespace-separated list of FATE tests to ignore
> + (without "fate-" prefix in the name)
>
> NOTE: Object files are built at the place where configure is launched.
> EOF
> @@ -1799,6 +1801,7 @@ CMDLINE_SET="
> host_ldflags
> host_libs
> host_os
> + ignore_tests
> ld
> logfile
> malloc_prefix
> @@ -5189,6 +5192,12 @@ for type in decoder encoder hwaccel parser demuxer
> muxer protocol filter bsf ind
> echo
> done
>
> +if test -n "$ignore_tests"; then
> + echo "Ignored FATE tests:"
> + echo $ignore_tests | print_3_columns
> + echo
> +fi
> +
> license="LGPL version 2.1 or later"
> if enabled nonfree; then
> license="nonfree and unredistributable"
> @@ -5313,6 +5322,7 @@ SLIB_INSTALL_EXTRA_LIB=${SLIB_INSTALL_EXTRA_LIB}
> SLIB_INSTALL_EXTRA_SHLIB=${SLIB_INSTALL_EXTRA_SHLIB}
> VERSION_SCRIPT_POSTPROCESS_CMD=${VERSION_SCRIPT_POSTPROCESS_CMD}
> SAMPLES:=${samples:-\$(LIBAV_SAMPLES)}
> +IGNORE_TESTS=$ignore_tests
> EOF
>
> get_version(){
> diff --git a/doc/fate.texi b/doc/fate.texi
> index 9b8d953..1cc7c6c 100644
> --- a/doc/fate.texi
> +++ b/doc/fate.texi
> @@ -139,6 +139,7 @@ workdir= # directory in
> which to do all the work
> fate_recv="ssh -T fate@@fate.libav.org" # command to submit report
> comment= # optional description
> build_only= # set to "yes" for a compile-only instance that skips tests
> +ignore_tests=
I think for use in fate proper broken_tests would be preferable since
fate might not ignore tests but could do something if a
broken/ignored test passes. Sorry I didn't bring that up in the prvious
review but you weren't touching fate. I assumed you wanted to pass it
via extra_config.
> # the following are optional and map to configure options
> arch=
> diff --git a/tests/Makefile b/tests/Makefile
> index 36a3a72..9535498 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -142,7 +142,9 @@ endif
>
> FATE_UTILS = base64 tiny_psnr
>
> -fate: $(FATE)
> +
> +fate: $(filter-out $(addprefix fate-,$(IGNORE_TESTS)),$(FATE))
> +
why the additional empty lines? If it's for highlighting this line a
comment would be better.
Janne
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
