On Sat, Oct 22, 2016 at 12:08:53PM +0200, Janne Grunau wrote: > On 2016-10-21 21:39:56 +0200, Diego Biurrun wrote: > > --- a/doc/fate.texi > > +++ b/doc/fate.texi > > @@ -139,6 +139,7 @@ workdir= # directory in > > which to do all the work > > fate_recv="ssh -T fate@@fate.libav.org" # command to submit report > > comment= # optional description > > build_only= # set to "yes" for a compile-only instance that skips tests > > +ignore_tests= > > I think for use in fate proper broken_tests would be preferable since > fate might not ignore tests but could do something if a > broken/ignored test passes. Sorry I didn't bring that up in the prvious > review but you weren't touching fate. I assumed you wanted to pass it > via extra_config.
For now the test is not run, i.e. ignored. If this gets changed to behave differently, sure, the name can change. Until then I believe it should match the name of the configure option. > > --- a/tests/Makefile > > +++ b/tests/Makefile > > @@ -142,7 +142,9 @@ endif > > > > FATE_UTILS = base64 tiny_psnr > > > > -fate: $(FATE) > > + > > +fate: $(filter-out $(addprefix fate-,$(IGNORE_TESTS)),$(FATE)) > > + > > why the additional empty lines? If it's for highlighting this line a > comment would be better. No, that's a stray change that slipped through, thanks for noticing. Changed locally. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
