On 09.02.2007 [13:46:18 +1100], David Gibson wrote: > On Thu, Feb 08, 2007 at 06:09:34PM -0800, Nishanth Aravamudan wrote: > > ehdr has global scope in elflink.c, it doesn't need to be passed > > around. > > Err... I'd really prefer to pass it. I think it's logically sensible > for parse_phdrs() to take a parameter, even if in practice we only > call it once.
Then why don't we remove ehdr from global scope? Would mean passing it around perhaps more, but would also make the code more explicit. Thanks, Nish -- Nishanth Aravamudan <[EMAIL PROTECTED]> IBM Linux Technology Center ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Libhugetlbfs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
