On Thu, 2007-02-22 at 12:28 -0600, Steve Fox wrote:
> On Mon, 2007-02-12 at 20:48 -0800, Nishanth Aravamudan wrote:
> > On 13.02.2007 [15:24:26 +1100], David Gibson wrote:
> > >
> > > Hrm. The later functions that need the data from find_dynamic() take
> > > the seg_info table. The idea is that the seg_info table provides all
> > > the necessary info for remapping the segments later, so we can avoid
> > > passing ehdr around by moving the parsing of the extracopy information
> > > to parse_phdrs() and storing it in the seg_info table.
> >
> > That's probably a good idea. I can make that part of the "store
> > extracopy information" patch stack, Steve, if you want to try and base
> > such a patch off of those?
>
> Sorry for the delay. Here's the requested patch.
>
> elflink: Move ELF header pointer from a global into seg_info struct.
>
> Signed-off-by: Steve Fox <[EMAIL PROTECTED]>
>
> ---
>
> diff --git a/elflink.c b/elflink.c
> index 9e4f6a0..0c8ec0c 100644
> --- a/elflink.c
> +++ b/elflink.c
> @@ -191,6 +191,7 @@ struct seg_info {
> int prot;
> int fd;
> int phdr;
> + Elf_Ehdr *ehdr;
> };
I don't think this is the right way to structure the data. There is one
to many relationship for ehdr->segment, but you are creating space to
store an ehdr pointer for each segment in the seg array.
--
Adam Litke - (agl at us.ibm.com)
IBM Linux Technology Center
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Libhugetlbfs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
