On 13.02.2007 [15:24:26 +1100], David Gibson wrote: > On Fri, Feb 09, 2007 at 03:25:28PM -0600, Steve Fox wrote: > > On Fri, 2007-02-09 at 16:04 +1100, David Gibson wrote: > > > On Thu, Feb 08, 2007 at 08:50:56PM -0800, Nishanth Aravamudan wrote: > > > > > > > > Then why don't we remove ehdr from global scope? Would mean passing it > > > > around perhaps more, but would also make the code more explicit. > > > > > > That sounds like a much better idea. > > > > Unfortunately that would mean passing a pointer around several layers of > > sub-functions which don't even need the pointer.. really ugly (see > > below). We really only need this pointer inside parse_phdrs() and > > find_dynamic(). Maybe someone can think of clever way to get it > > there? > > Hrm. The later functions that need the data from find_dynamic() take > the seg_info table. The idea is that the seg_info table provides all > the necessary info for remapping the segments later, so we can avoid > passing ehdr around by moving the parsing of the extracopy information > to parse_phdrs() and storing it in the seg_info table.
That's probably a good idea. I can make that part of the "store extracopy information" patch stack, Steve, if you want to try and base such a patch off of those? Thanks, Nish -- Nishanth Aravamudan <[EMAIL PROTECTED]> IBM Linux Technology Center ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Libhugetlbfs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
