On 23.02.2007 [10:50:27 +1100], David Gibson wrote: > On Thu, Feb 22, 2007 at 02:59:36PM -0600, Steve Fox wrote: > > On Thu, 2007-02-22 at 13:17 -0600, Adam Litke wrote: > > > I don't think this is the right way to structure the data. There is one > > > to many relationship for ehdr->segment, but you are creating space to > > > store an ehdr pointer for each segment in the seg array. > > > > Yes. I thought about that, but thought that was what David was asking > > for anyway. I had a cleaner version, but it wasn't working on x86 and > > x86_64 .xB for some reason. > > Ah, no, I think you misunderstood. Nack on that first patch. > > > I've looked at it again and found a much nicer way to do this. Nish did > > the same thing too, but he added some extra clean-ups, so I've asked him > > to post his version instead. > > Yes, that looks much more like what I had in mind, moving > get_extracopy() to parse_pdrs(). Incidentally, now tgat parse_phdrs() > does that, it's actually doing more than just examining the program > headers, so possibly we should rename it parse_elf() or something.
Yep, ISTR after doing my patch that there are a handful of other renames I'd like to do, as well. I'll see what they are throw out a patch soon. Thanks, Nish -- Nishanth Aravamudan <[EMAIL PROTECTED]> IBM Linux Technology Center ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Libhugetlbfs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
