On Fri, 2007-02-23 at 14:35 -0800, Nishanth Aravamudan wrote: > @@ -831,6 +865,23 @@ static void remap_segments(struct seg_info *seg, int num) > /* The segments are all back at this point. > * and it should be safe to reference static data > */ > + > + /* > + * This pagecache dropping code should not be used for shared segments. > + * But we currently only share read-only segments, so the below check > + * for PROT_WRITE is implicitly sufficient. > + * > + * Note: if minimal_copy is enabled, it is overkill to try and I think you want to say "if minimal_copy is off." Otherwise, it looks good to me.
-- Adam Litke - (agl at us.ibm.com) IBM Linux Technology Center ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Libhugetlbfs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
