On Thu, Feb 4, 2016 at 9:35 PM, Roy Stogner <royst...@ices.utexas.edu>
wrote:
>
> On Thu, 4 Feb 2016, David Knezevic wrote:
>
> The order member in FEType is public, and it's used in many places,
>> so changing the order member necessitates lots of other changes in
>> the library (for example, consider all the methods in the FE class
>> that expect fe_type.order to provide an Order enum).
>>
>
> And we don't want to do that, at least not without years of backwards
> compatibility, because there's probably a lot of non-library code
> relying on fe_type.order too.
>
> I'm not sure I see a good way to do this while retaining backwards
>> compatibility.
>>
>
> With an accessor class? Create an OrderShim class that stores an int
> internally, gets queried by the FEType class to return that int, but
> has an operator Order to implictly convert that int to an Order.
>
OK, good idea. I made a PR with this approach. Not sure if I handled the
implicit type conversion stuff properly, so please have a look and let me
know what you think.
David
------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140
_______________________________________________
Libmesh-devel mailing list
Libmesh-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libmesh-devel
