On Fri, May 30, 2008 at 12:33 PM, Roy Stogner <[EMAIL PROTECTED]> wrote: > >> Sounds like a good plan, along the lines of your changes of error() -> >> libmesh_error(), etc. While we're at it, should we also consider >> similar changes for the other #defines in libmesh_config.h? For >> example, all the HAVE_LIBRARYFOO would become LIBMESH_HAVE_LIBRARYFOO, >> etc. Granted, these are less likely than DIM to trip over other >> libraries but as the library gets more mature I think this is a >> natural progression... > > Not a bad idea. We'd also stick some temporary lines like: > > #define HAVE_LIBRARYFOO LIBMESH_HAVE_LIBRARYFOO > > at the bottom of libmesh_config.h? Just something for 0.6.9 to be
AFAIK, libmesh_config.h.in is auto-generated by autoconf/autoheader, and libmesh_config.h is auto-generated from it. I agree with you that we should try to keep things backwards-compatible though... One way to accomplish this might be to modify all the configure tests to define both HAVE_LIBRARYFOO and LIBMESH_HAVE_LIBRARYFOO simultaneously. In this case, though, I'd be worried about breaking configure tests... and it sounds like a lot of work. If you have any other ideas I'd be happy to hear them. Changing these #defines seems like a fairly straightforward task, though, and I'd like to take a crack at it. -J > removed in 0.7.0, like the current error() macro. I don't see any > good way to give a deprecated() type warning to applications that > still use the old macros, but we could at least give users a little > bit of forwards/backwards compatibility so that anyone using such > macros in their own code doesn't have to change application code at > the *exact* same time as they upgrade the library. > --- > Roy > ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Libmesh-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libmesh-users
