On Fri, 30 May 2008, John Peterson wrote:

> AFAIK, libmesh_config.h.in is auto-generated by autoconf/autoheader,
> and libmesh_config.h is auto-generated from it.

Whoops - you're right.  I remembered about the autoconf stuff, but
forgot about autoheader.  In fact, for the last couple new configure
tests I added, I forgot to run autoheader and I just edited
libmesh_config.h.in by hand!  :-P

> I agree with you that we should try to keep things
> backwards-compatible though...
>
> One way to accomplish this might be to modify all the configure tests
> to define both HAVE_LIBRARYFOO and LIBMESH_HAVE_LIBRARYFOO
> simultaneously.  In this case, though, I'd be worried about breaking
> configure tests...  and it sounds like a lot of work.

Yeah, my autoconf skills also lean towards "touch configure.in as
little as possible".  We could add AC_DEFINE_UNQUOTED entries, I
suppose; that would be straightforward enough.  It looks like
autoheader sorts things alphabetically, but that shouldn't be a
problem, right?  Whether "#define LIBMESH_FOO FOO" comes before or
after "#define FOO BAR", it should still work.

> If you have any other ideas I'd be happy to hear them.  Changing
> these #defines seems like a fairly straightforward task, though, and
> I'd like to take a crack at it.

Thanks; go for it!  I wasn't sure I'd be able to get around to this
tomorrow anyway, so I'll wait for you to take the first shot at the
changes, and if there's any problems or if you can't find the time
then I'll get to it in a week.
---
Roy

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Libmesh-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/libmesh-users

Reply via email to