https://bugs.documentfoundation.org/show_bug.cgi?id=166723
--- Comment #8 from Eyal Rozenberg <[email protected]> --- (Caveat: I am basing this comment on the blog post description of the feature) "Reinstate" is simply an incorrect, and quite confusing description of this action: Reinstatement takes something that had been unstated (stripped or deprived of office, rank, state, status), and "instates" it once again (restores its office, rank, state, status). In our case, we don't have a binary of "with state", "without state", since content can be: * In the document with a proposition to change it * A proposition of change to the document * Non-existent/gone (and that's ignoring the fact that a change can itself be an addition, deletion, or modification with no addition or deletion) So, please confirm this bug! ----- Now, what shall we use instead? Definitely not a synonym of "reinstate". In fact, this action can be achieved by accepting the change, then undoing it while tracking. So, here are several ideas, although I'm not thrilled about any of them: * "Accept then Suggest an Undo" * "Accept then Suggest Undo" * "Accept then Undo" * "Accept & Track Revert" * "Accept & Track Reversion" * "Accept & Revert" THe following suggestions are vague, but - they have the benefit of quite difficult to misinterpret, which is a plus: * "Invert suggestion" * "Invert change" * "Flip to reversion" * "Invert" --------------------------- Comments on other suggestions: (In reply to V Stuart Foote from comment #1) > 'Declined' with prejudice, i.e 'Dropped', as opposed to 'Rejected' but kept > for tracking. Ah, but the change is more accepted than it is declined. (In reply to Heiko Tietze from comment #4) > "Reject and Retain" (isn't this kind of an oxymoron?) sounds good > after pondering a while over the topic but I doubt it helps casual users. Same point as above: This does not reject the change, it _accepts_ the change. But instead of retaining the accepted change, it (In reply to Heiko Tietze from comment #4) > Thesaurus comes up with repudiate, refuse, decline, discard... Which is why we definitely should not use any of those :-( (In reply to Telesto from comment #5) > Revert I think "Invert" captures the semantics better. > Revive > Resurrect > Resuscitate > > Resurrect appears to describe the action pretty well, I think. But nothing has died! What are you resurrecting? And what does it mean to be "alive" rather than "dead"? We don't use that metaphor anywhere w.r.t. track changes. > Restore > Reinstitute But nothing has been lost. This is too close to being a synonym of reinstate. (In reply to Tuomas Hietala from comment #7) > Perhaps "Decline and Retain" would sound less oxymoronic? Same point as in my replies to Stuart and Heiko: We're not declining, we're accepting. "Decline and Retain" for a proposed change would be a no-op. > I think it will be helpful if we use terms that make it clear that the two > functions are closely related. Disagree. What is now "reinstate" is both similar and opposite to "accept" and to "reject" - depending on whether, after the "reinstate", you accept-all changes or reject-all changes; i.e. whether you think of the proposed document or the unaltered document. ------------------------ Other comments: (In reply to Miklos Vajna from comment #2) > Perhaps add a tooltip to give more information? Definitely, but that should happen regardless. > There are 116 references to reinstate in the code by now, so renaming the > actual UNO command would not be ideal. On the contrary, it's important we do so now, before there are 1160 references to "reinstante". (In reply to Tuomas Hietala from comment #3) > I think usually when user-facing strings change in LO, the developer-facing > names in the code are not changed. But that's really up to the developer(s) > to decide. IMNSHO, it's better if this is changed for developers as well, since they are also people and would definitely be confused by this phrase - especially when the UI calls it something different. -- You are receiving this mail because: You are the assignee for the bug.
