"Beautify" is appropriate for changes in comments or formatting. For code, it is subjective and non-descriptive. Overall, the changes look like an improvement.
https://codereview.appspot.com/264950043/diff/1/lily/break-substitution.cc File lily/break-substitution.cc (right): https://codereview.appspot.com/264950043/diff/1/lily/break-substitution.cc#newcode446 lily/break-substitution.cc:446: orig->filter_map_into(substitute_grob, *new_arr); Coding style mishap, missing space: filter_map_into ( https://codereview.appspot.com/264950043/diff/1/lily/break-substitution.cc#newcode492 lily/break-substitution.cc:492: grob_array->filter_map_into(substitute_grob, *new_arr); Coding style. https://codereview.appspot.com/264950043/diff/1/lily/grob-array.cc File lily/grob-array.cc (right): https://codereview.appspot.com/264950043/diff/1/lily/grob-array.cc#newcode88 lily/grob-array.cc:88: // could call grobs_.shrink_to_fit() with C++11 Coding style: shrink_to_fit () https://codereview.appspot.com/264950043/diff/1/lily/grob-array.cc#newcode99 lily/grob-array.cc:99: // could call grobs_.shrink_to_fit() with C++11 Coding style. https://codereview.appspot.com/264950043/diff/1/lily/grob-array.cc#newcode102 lily/grob-array.cc:102: // Like filter_map(f), but store the result in the given array. Coding style. https://codereview.appspot.com/264950043/diff/1/lily/grob-array.cc#newcode105 lily/grob-array.cc:105: Grob_array &result) const Conceptually this is not a member function, at least not of the _source_ Grob_array. It's more of an assignment/initialization. So it's more of a Grob_array & Grob_array::filter_map_assign (Grob * (*map_fun) (Grob*), const Grob_array &src); https://codereview.appspot.com/264950043/diff/1/lily/grob-array.cc#newcode114 lily/grob-array.cc:114: // could call result.grobs_.shrink_to_fit() with C++11 Coding style. https://codereview.appspot.com/264950043/diff/1/lily/include/grob-array.hh File lily/include/grob-array.hh (right): https://codereview.appspot.com/264950043/diff/1/lily/include/grob-array.hh#newcode64 lily/include/grob-array.hh:64: // set_ordered(), which could lead to unexpected behavior. Coding style. https://codereview.appspot.com/264950043/diff/1/lily/include/grob-array.hh#newcode67 lily/include/grob-array.hh:67: // Like filter_map(f), but store the result in the given array. Coding style. https://codereview.appspot.com/264950043/diff/1/lily/include/grob-array.hh#newcode70 lily/include/grob-array.hh:70: // set_ordered(), which could lead to unexpected behavior. Coding style. https://codereview.appspot.com/264950043/diff/1/lily/pure-from-neighbor-interface.cc File lily/pure-from-neighbor-interface.cc (right): https://codereview.appspot.com/264950043/diff/1/lily/pure-from-neighbor-interface.cc#newcode45 lily/pure-from-neighbor-interface.cc:45: a->set_array(new_elts); Coding style. https://codereview.appspot.com/264950043/diff/1/lily/slur.cc File lily/slur.cc (right): https://codereview.appspot.com/264950043/diff/1/lily/slur.cc#newcode223 lily/slur.cc:223: a->set_array(new_encompasses); Coding style. https://codereview.appspot.com/264950043/ _______________________________________________ lilypond-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/lilypond-devel
