On 2015/09/03 08:49:13, dak wrote:
On 2015/09/02 23:27:41, Dan Eble wrote:
> If the sorting criterion uses attributes of the Grob that are
changed by
> replacement, the array might not be sorted afterward (or might be
sorted when
it > wasn't before). Grob_array does not appear to dictate the sorting
criterion. The flag 'ordered_' is used to protect an array from re-arrangement, such as the order of staves in a system, rather than to report whether the array has been sorted. See its only use at https://codereview.appspot.com/264950043/diff/40001/lily/break-substitution.cc#newcode300 where it prevents an optimization that would otherwise re-order the array. If filter_map() does change the conceptual order in this way, then it may not be used on an array marked as ordered_.
So the routine should reset the "sorted" flag when any changes are
made? In this case, the converse: If 'ordered_' is set, no changes may be made. The safer, more conservative, setting of 'ordered_' is 'true'. https://codereview.appspot.com/264950043/ _______________________________________________ lilypond-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/lilypond-devel
