On Tue, 15 Jan 2002, Russell King - ARM Linux wrote:

> On Tue, Jan 15, 2002 at 04:25:11PM -0500, Nicolas Pitre wrote:
> > ISA isn't just a wiring standard.  It's also lists of typical IO address to 
> > probe for the existence of some particular hardware.  That stuff is of 
> > course part of the .c driver file.  On the SA11x0 all those probes must of 
> > course be configured out and surrounding them with #ifdef CONFIG_ISA instead 
> > of #if !defined(CONFIG_SA1100_X) && !defined(CONFIG_FOO) && 
> > !defined(CONFIG_BAR) seems much more tasteful to me.
> 
> Its not tasteful to Alan.  Alan suggested back in the 2.4-ac days that we
> abstract inb/outb and friends to handle the mess that became smc9194.c
> so that all the platform specific magic is handled within there, rather
> than dropping lots of random machine specifics all over the various
> drivers.

I agree on that.  I just don't buy the "CONFIG_ISA always on" argument.


Nicolas


_______________________________________________
http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm
Please visit the above address for information on this list.

Reply via email to