Hi Raoul, > why do you want to return here and not simply break and let the > postfix_stop() continue it's work?
No, I do not have any problem even if I use the break sentence. It is my preference to have used the return sentence. Cheers, Hideo Yamauchi. --- On Mon, 2011/11/14, Raoul Bhatia [IPAX] <[email protected]> wrote: > hi! > > thanks for your contribution! > > On 2011-11-14 07:04, [email protected] wrote: > > diff -r 52dcb4318e21 heartbeat/postfix > > --- a/heartbeat/postfix Mon Nov 14 14:46:36 2011 +0900 > > +++ b/heartbeat/postfix Mon Nov 14 14:47:03 2011 +0900 > ... > > @@ -168,14 +171,17 @@ > > > > # grant some time for shutdown and recheck 5 times > > for i in 1 2 3 4 5; do > > - if postfix_running; then > > + if postfix_running info; then > > sleep 1 > > + else > > + ocf_log info "Postfix stopped." > > + return $OCF_SUCCESS > > fi > > done > why do you want to return here and not simply break and let the > postfix_stop() continue it's work? > > > besides that, your patch looks fine upon the first check. > > cheers, > raoul > -- > ____________________________________________________________________ > DI (FH) Raoul Bhatia M.Sc. email. [email protected] > Technischer Leiter > > IPAX - Aloy Bhatia Hava OG web. http://www.ipax.at > Barawitzkagasse 10/2/2/11 email. [email protected] > 1190 Wien tel. +43 1 3670030 > FN 277995t HG Wien fax. +43 1 3670030 15 > ____________________________________________________________________ > _______________________________________________________ Linux-HA-Dev: [email protected] http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
