On 2011-11-15 10:19, Raoul Bhatia [IPAX] wrote:
> On 2011-11-15 10:10, [email protected] wrote:
>> I think that the correction that you suggested is right.
>> I approve of it.
>
> thanks.
>
> i just pushed it to my resource-agents branch [1][2]
> i will look at your patch regarding the data_directory soon.
>
> thank you for your contribution!
> raoul

i forgot to add the break inside the loop.
the fix has been applied and has been pushed to my repo [1][2]


there is one thing i noticed though, which i think kind of
suboptimal:

upon starting, we log the following:

> Nov 18 15:01:14 m01 crmd: [2063]: info: do_lrm_rsc_op: Performing 
> key=114:55889:0:9582c8d2-c69a-4d79-91f6-04ea7bbe1853 
> op=m-mail-postfix_start_0 )
> Nov 18 15:01:14 m01 lrmd: [2060]: info: rsc:m-mail-postfix start[176] (pid 
> 12172)
> Nov 18 15:01:14 m01 postfix/postfix-script[12326]: the Postfix mail system is 
> not running
> Nov 18 15:01:14 m01 postfix[12172]: INFO: Postfix status: ''. 1
> Nov 18 15:01:14 m01 postfix/postfix-script[12475]: starting the Postfix mail 
> system
> Nov 18 15:01:14 m01 postfix/master[12476]: daemon started -- version 2.8.3, 
> configuration /data/mail/conf
> Nov 18 15:01:15 m01 postfix/postfix-script[12804]: the Postfix mail system is 
> running: PID: 12476
> Nov 18 15:01:15 m01 postfix[12172]: INFO: Postfix started.

there is one line that i would like to do something about:

> Nov 18 15:01:14 m01 postfix[12172]: INFO: Postfix status: ''. 1

1. we do not capture the "the Postfix mail system is not running"
    output. maybe this is a result from running in an interactive shell?

2. we log an error (rc 1) which actually is expected and good
   (postfix is not running; we're eligible to start it)

the same happens upon stopping postfix:
> Nov 18 15:01:07 m01 crmd: [2063]: info: do_lrm_rsc_op: Performing 
> key=116:55885:0:9582c8d2-c69a-4d79-91f6-04ea7bbe1853 op=m-mail-postfix_stop_0 
> )
> Nov 18 15:01:07 m01 lrmd: [2060]: info: rsc:m-mail-postfix stop[175] (pid 
> 10420)
> Nov 18 15:01:08 m01 postfix/postfix-script[10632]: the Postfix mail system is 
> not running
> Nov 18 15:01:08 m01 postfix[10420]: INFO: Postfix status: ''. 1
> Nov 18 15:01:08 m01 postfix/postfix-script[10652]: the Postfix mail system is 
> not running
> Nov 18 15:01:08 m01 postfix[10420]: INFO: Postfix status: ''. 1
> Nov 18 15:01:08 m01 postfix[10420]: INFO: Postfix stopped.
> Nov 18 15:01:08 m01 lrmd: [2060]: info: operation stop[175] on m-mail-postfix 
> for client 2063: pid 10420 exited with return code 0


do you have any ideas?
do you see the same output?

on my test system, i'm running postfix 2.8.3.

cheers,
raoul
[1] https://github.com/raoulbhatia/resource-agents/tree/postfix
[2] https://github.com/raoulbhatia/resource-agents/commits/postfix
-- 
____________________________________________________________________
DI (FH) Raoul Bhatia M.Sc.          email.          [email protected]
Technischer Leiter

IPAX - Aloy Bhatia Hava OG          web.          http://www.ipax.at
Barawitzkagasse 10/2/2/11           email.            [email protected]
1190 Wien                           tel.               +43 1 3670030
FN 277995t HG Wien                  fax.            +43 1 3670030 15
____________________________________________________________________
_______________________________________________________
Linux-HA-Dev: [email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Reply via email to