Hi Raoul,

Thank you for comment.

> 1. simply break the loop when postfix isn't running anymore.
> 2. ocf_log info "Postfix stopped." will be called at the end of the
>    postfix_stop() method.
> 
> any objections?

All right.

I think that the correction that you suggested is right.
I approve of it.

Thanks,
Hideo Yamauchi.

--- On Tue, 2011/11/15, Raoul Bhatia [IPAX] <[email protected]> wrote:

> hi Hideo-san!
> 
> On 2011-11-15 01:14, [email protected] wrote:
> > Hi Raoul,
> > 
> >> why do you want to return here and not simply break and let the
> >> postfix_stop() continue it's work?
> 
> ok, so i would change the patch to:
> 
> > --- a/heartbeat/postfix
> > +++ b/heartbeat/postfix
> > @@ -173,6 +173,8 @@ postfix_stop()
> >      for i in 1 2 3 4 5; do
> >          if postfix_running info; then
> >              sleep 1
> > +        else
> > +            break
> >          fi
> >      done
> 
> 1. simply break the loop when postfix isn't running anymore.
> 2. ocf_log info "Postfix stopped." will be called at the end of the
>    postfix_stop() method.
> 
> any objections?
> 
> thanks,
> raoul
> -- ____________________________________________________________________
> DI (FH) Raoul Bhatia M.Sc.          email.          [email protected]
> Technischer Leiter
> 
> IPAX - Aloy Bhatia Hava OG          web.          http://www.ipax.at
> Barawitzkagasse 10/2/2/11           email.            [email protected]
> 1190 Wien                           tel.               +43 1 3670030
> FN 277995t HG Wien                  fax.            +43 1 3670030 15
> ____________________________________________________________________
> 
_______________________________________________________
Linux-HA-Dev: [email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Reply via email to