On Wed, Jun 25, 2008 at 5:49 PM, Dejan Muhamedagic <[EMAIL PROTECTED]> wrote: > On Wed, Jun 25, 2008 at 03:20:02PM -0600, Serge Dubrouski wrote: >> >> Should I change pgsql in a way that it'll >> >> return OCF_ERR_UNIMPLEMENTED for any unknown operation? >> > >> > yes - because the RA doesn't know how to deal with it >> >> Ok. Then the correct pacth would be as attached. Thanks for the explanation. > > A long story - a short patch :) and the morale: > always include a default clause for the switch statement
Nope. There was a default for OCF_ERRARGS and I conidered that one as a correct one for umknown operations. Per my opinion OCF_ERR_UNIMPLEMNTED should be used for legal, i.e. defined by the OCF standard, operations only. > > Cheers, > > Dejan > >> >> -- >> Serge Dubrouski. > > >> _______________________________________________ >> Linux-HA mailing list >> [email protected] >> http://lists.linux-ha.org/mailman/listinfo/linux-ha >> See also: http://linux-ha.org/ReportingProblems > _______________________________________________ > Linux-HA mailing list > [email protected] > http://lists.linux-ha.org/mailman/listinfo/linux-ha > See also: http://linux-ha.org/ReportingProblems > -- Serge Dubrouski. _______________________________________________ Linux-HA mailing list [email protected] http://lists.linux-ha.org/mailman/listinfo/linux-ha See also: http://linux-ha.org/ReportingProblems
