On Tue, Jul 08, 2025 at 08:27:50AM +0200, Krzysztof Kozlowski wrote:
> On 08/07/2025 08:20, Shawn Guo wrote:
> >> +
> >> + backlight: backlight {
> >> + compatible = "pwm-backlight";
> >> + pwms = <&pwm1 0 500000 0>;
> >> + power-supply = <®_5v>;
> >> + brightness-levels = <0 100>;
> >> + num-interpolated-steps = <100>;
> >> + default-brightness-level = <100>;
> >> + status = "okay";
> >
> > We usually use "okay" status to enable "disabled" devices. It doesn't
> > seem to be needed here.
>
> I already asked for this in v2. Changelog claims it was done, but I
> believe nothing here improved and they just sent the same patchset
> wasting review effort.
Sorry, I removed it for lvds but missed backlight. I will send new series
with a correction.
Best Regards,
Wojtek
>
> Best regards,
> Krzysztof
