On Mon, Aug 21, 2006, EV wrote: > 2006-08-21: EV dixit: > > I'll send the patch later tonight, hopefully after Franky has > > updated the repository to changeset 105 with your latest patch. > > Please wait for this one before sending new patches! > > Find it attached. Keith, please review the rio_rw.c changes > since I think they mainly affect code recently written by you. > I have not dared to introduce the other changes I mentioned (as I > don't understand taglib sufficiently):
Not got time to read it properly but I'm not sure that I like it. It appears that you now build the properties list *before* checking for duplicates and then delete it again at the end. I preferred the previous method of only creating properties after checking for duplicates. What was your reason for changing it? > 2006-08-21: EV dixit: > > [...] make some changes to rio_rw.c; mainly to avoid non-atomic > > setting of path-defining properties, which makes the virtual > > files just evaporate while calling taglib [...] > > The idea is not to set any default genre, artist, source or title > *before* calling taglib. Instead, wait to see if taglib doesn't Why should this matter? > It seems fairly trivial, but I don't want to break something > related with taglib. So I leave it for you or Franky. Thanks! I also think that the fdb locking fix is the wrong way to go. The old version of riocp only grabs an i/o lock when there is something to write. This is correct behaviour. The problem is that the fdb file is uploaded regardless of whether anything has changed. This can be fixed if we have a flag which gets set when the properties change. I implemented this fix last night and it seems to do the job, although I haven't done much testing yet. On a related note, I think that the library should be a bit smarter about i/o locking. There should be flags for read/write io locks and the functions which require a lock to be held can then check those flags before attempting the operation. I will need help to implement this as the ethernet protocol does not seem to be particularly well documented with respect to i/o locking. Keith. ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ linux-karma-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-karma-devel
