On Tue, Aug 22, 2006, EV wrote: > BTW, I also want to take rid computing and rid property setting > outside lk_rio_update_props_from_tags(). The reason is that rid > computing takes the lion share of the computing load and,
I can see the advantage of checking for dupes based on the tags before checking the rid. I still think that rid generation belongs in this routine, though. You expect the properties to be correct after this call completes and the rid is one of those properties. > moreover, eventually I'd like to compute it incrementally within > lkarmafs kfs_readdir() call. I diden't take it out because it ??? The rid is computed when files are *uploaded*. What does that have to do with readdir() ? Any track present on the karma should already have a valid rid. > seems to need some info provided by the mp3 tags. Is that true? Not quite. The rid is computed for the audio data only, so you first have to scan the header (with the tags) to find out how big it is. This is done in get_file_type(). You don't actually have to read the tags at this stage. Keith. ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ linux-karma-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-karma-devel
