On Wed, 2016-04-27 at 16:48 +0300, Andy Shevchenko wrote: > + bool polarity;
So this variable is not very intuitively named. You end up setting somepointer->polarity = true; in a later patch. Since you're respining a V4 I'd suggest a name that describes a little bit better than polarity. Setting polarity = true is a little bit liked being asked "you you like ice-cream or apple pie" and then saying "yes please". --- bod
